search

jpadilla / pyjwt

JSON Web Token implementation in Python
https://pyjwt.readthedocs.io
MIT License
5.1k stars 682 forks source link

Cryptography package, needed, but not as a requirement? #954

Closed vhdmoradi closed 4 months ago

vhdmoradi commented 4 months ago

I was working with PyJWT package in my api, and was struggling with "Algorithm not supported" error for over 2 hours; checking each line of my code to figure out where I've made a mistake. Until I came to realization that it is due the fact that I do not have cryptography package installed. If this package is essential for the usage, shouldn't it be as a requirement and autamitically installed when installing PyJWT?

jpadilla commented 4 months ago

some algorithms don't require the package.

vhdmoradi commented 4 months ago

Yeah, But some do! I mean, requirements usually are required in some places of a code, not all of it. Still, we name it as a requirement and install it at the beginning. Your repo, your decision, I am just saying requrements are requirements as long as they are used, even once; does not matter on how many places you use them.