search

jpage8580 / GTUltra

GTUltra - Extensively modified GoatTracker Stereo (2.76) version. With many new features. See the GTUltra.PDF file for full details
GNU General Public License v2.0
88 stars 10 forks source link

sidaddress initialized wrong #27

Open drmortalwombat opened 2 years ago

drmortalwombat commented 2 years ago

in gt2stereo.c

unsigned sidaddress = 0xd400d420;

should be

unsigned sidaddress = 0xd420d400;

so that the first SID is at address 0xd400 and the second at 0xd420

see greloc.c:

int sidAddr1 = sidaddress & 0xffff; int sidAddr2 = (sidaddress >> 16) & 0xffff;

aquamarine-axo commented 2 years ago

this could possibly be why 2SID tunes export incorrectly for me then

jpage8580 commented 2 years ago

These should be overwritten with the values you specify when exporting. So the initial values shouldn’t matter.

On Sun, 19 Jun 2022 at 16:13, nicco1690 @.***> wrote:

this could possibly be why 2SID tunes export incorrectly for me then

— Reply to this email directly, view it on GitHub https://github.com/jpage8580/GTUltra/issues/27#issuecomment-1159752368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGMDBXAU3PCSRXT74GLEMTVP42J5ANCNFSM5ZGQAQCQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

drmortalwombat commented 2 years ago

You can only overwrite the 2nd sid, not the first, which is stuck at 0xd420

jpage8580 commented 2 years ago

Will take a look. I’m currently rewriting this code so that it uses unique 3SID / 4SiD 6502 code, (obviously 4 SID will not play correctly in any SID player due to format limitations )

On Sun, 19 Jun 2022 at 16:21, drmortalwombat @.***> wrote:

You can only overwrite the 2nd sid, not the first, which is stuck at 0xd420

— Reply to this email directly, view it on GitHub https://github.com/jpage8580/GTUltra/issues/27#issuecomment-1159754482, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGMDBXOMOGEWFBYDE6U66LVP43I7ANCNFSM5ZGQAQCQ . You are receiving this because you commented.Message ID: @.***>

jpage8580 commented 2 years ago

Fixed my local version - First SID is now forced to $D400, Second SID is loaded from cfg file (correctly!) Have also creates a new player9.s file for 9 channel SIDs, so no longer needing to force / hack 2 SID files to work together. Will do the same for the altplayer.s file and then do the same for 12 channel SID.

Sorry about the problems.

On Sun, Jun 19, 2022 at 4:52 PM Jason Page @.***> wrote:

Will take a look. I’m currently rewriting this code so that it uses unique 3SID / 4SiD 6502 code, (obviously 4 SID will not play correctly in any SID player due to format limitations )

On Sun, 19 Jun 2022 at 16:21, drmortalwombat @.***> wrote:

You can only overwrite the 2nd sid, not the first, which is stuck at 0xd420

— Reply to this email directly, view it on GitHub https://github.com/jpage8580/GTUltra/issues/27#issuecomment-1159754482, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGMDBXOMOGEWFBYDE6U66LVP43I7ANCNFSM5ZGQAQCQ . You are receiving this because you commented.Message ID: @.***>