jpage8580 / GTUltra

GTUltra - Extensively modified GoatTracker Stereo (2.76) version. With many new features. See the GTUltra.PDF file for full details
GNU General Public License v2.0
87 stars 10 forks source link

Packer/relocator sometimes says "OUT OF MEMORY IN PACKER/RELOCATOR" and crashes the program #32

Closed acrouzet closed 1 year ago

jpage8580 commented 2 years ago

Always with the same .sng ? How many channels? Need more details.

On Fri, 24 Jun 2022 at 23:17, acrouzet @.***> wrote:

— Reply to this email directly, view it on GitHub https://github.com/jpage8580/GTUltra/issues/32, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGMDBXXDVAY7VVPJPH25CLVQYXY5ANCNFSM5ZZEF53Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>

acrouzet commented 2 years ago

89.zip It's this .sng

jpage8580 commented 2 years ago

I can't repro. I've modified the code to hopefully give more info as to where this is happening (that same text output is displayed in 3 places when allocating memory for song, pattern and instrument data).

acrouzet commented 2 years ago

image This is the error I got.

jpage8580 commented 2 years ago

When did this start happening? Since this branch version? That size looks correct, which makes me think you are actually just out of memory. Does this happen as soon as you load the sng, or only after some time where you’ve edited the music?

I’ll add output to show available memory to the branch version. I couldn’t see this falling in my local version, so I don’t think there’s a memory leak.

On Sun, 26 Jun 2022 at 03:46, acrouzet @.***> wrote:

[image: image] https://user-images.githubusercontent.com/47704566/175797199-068ec8b4-6a42-4141-a263-155338c45e35.png This is the error I got.

— Reply to this email directly, view it on GitHub https://github.com/jpage8580/GTUltra/issues/32#issuecomment-1166403803, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGMDBVKABZVWQU7YR5FYWLVQ7AAZANCNFSM5ZZEF53Q . You are receiving this because you commented.Message ID: @.***>

acrouzet commented 2 years ago

It just started happening in the version that was the latest when I made the issue. It happened when I already composed part of the song.

jpage8580 commented 2 years ago

Just pushed another version that displays the available memory. Click on the record button to update it (checking constantly for available memory has the side-effect of reducing available memory over time due to fragmentation. ) Would be good to know if you're seeing a sudden drop during use for some reason, or if you're just starting off with a low amount. Only major change that I can think of is the change to screen size for this version. But considering what apps and games can do on a regular Windows PC today, I'd be surprised if that's causing the problem. I'm showing around 1.5gb of free RAM (app is win32, so I malloc would be limited to 4GB anyway, AFAIK)

acrouzet commented 2 years ago

Just pushed another version that displays the available memory. Click on the record button to update it (checking constantly for available memory has the side-effect of reducing available memory over time due to fragmentation. ) Would be good to know if you're seeing a sudden drop during use for some reason, or if you're just starting off with a low amount. Only major change that I can think of is the change to screen size for this version. But considering what apps and games can do on a regular Windows PC today, I'd be surprised if that's causing the problem. I'm showing around 1.5gb of free RAM (app is win32, so I malloc would be limited to 4GB anyway, AFAIK)

image This number doesn't change and yet I'm still getting the error message when trying to pack the same tune.

jpage8580 commented 2 years ago

Still can't replicate. Can you send me your gtultra.cfg file

acrouzet commented 2 years ago

gtultra.zip

jpage8580 commented 2 years ago

Still no luck in getting this to repro :-( I've pushed another version to the New-OrderList-View branch that displays more info when you pack (available memory / required memory that will be allocated).. I'd expect there to be a massive decrease in available memory prior to you getting the OUT OF MEMORY error. But I can't see why or how it gets into that situation.

My steps to try to repro:

Please let me know if you're doing anything differently

acrouzet commented 2 years ago

I have the number of SIDs set to 1 in the transport bar. I've also noticed that the memory error doesn't occur with a 2SID project I'm working on.

jpage8580 commented 2 years ago

Still can't repro. Let me know if the the free memory / allocated sizes in the latest branch version show anything unusual

acrouzet commented 2 years ago

Okay, so now the .sng seems to export without issue...