jpage8580 / GTUltra

GTUltra - Extensively modified GoatTracker Stereo (2.76) version. With many new features. See the GTUltra.PDF file for full details
GNU General Public License v2.0
87 stars 10 forks source link

Exporting 4xSID tunes can crash GTUltra #48

Open CINJ opened 1 year ago

CINJ commented 1 year ago

Version affected: 1.4.x

Symptom: export will crash at the step after specifying the options, SID addresses and addresses of the ZP to use.

Observations: Seems to crash specifically when Volume Change support or Sound Effect Support is enabled. Crash is literally just application shutdown

Platform: WIN32

jpage8580 commented 1 year ago

Can you send me the sng file that you’re using? This will be due a branch out of range in 6510

On Sun, 6 Nov 2022 at 10:32, Joe Cincotta @.***> wrote:

Version affected: 1.4.x

Symptom: export will crash at the step after specifying the options, SID addresses and addresses of the ZP to use.

Observations: Seems to crash specifically when Volume Change support or Sound Effect Support is enabled. Crash is literally just application shutdown

Platform: WIN32

— Reply to this email directly, view it on GitHub https://github.com/jpage8580/GTUltra/issues/48, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGMDBWEIHEEQXDVVLNWPJ3WG6CMLANCNFSM6AAAAAARYLR6GU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

jpage8580 commented 1 year ago

Absolutely. This is just to get things to crash. I won’t share and will delete as soon as possible.

Can you confirm how many sids this uses? I’d expect the crash to likely happen if saving as 3 or 4 sid only.

On Sun, 6 Nov 2022 at 10:41, Joe Cincotta @.***> wrote:

Pls don't share, this is for an unreleased demo. Maybe delete this comment once you download :)

megatune.zip https://github.com/jpage8580/GTUltra/files/9945617/megatune.zip

— Reply to this email directly, view it on GitHub https://github.com/jpage8580/GTUltra/issues/48#issuecomment-1304770679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGMDBUVWP4EY3UFFCRY3BLWG6DODANCNFSM6AAAAAARYLR6GU . You are receiving this because you commented.Message ID: @.***>

jpage8580 commented 1 year ago

There will likely be some kind of debug.s file that’s been saved before the crash. That’s the generated 6510 assembly.

On Sun, 6 Nov 2022 at 10:47, Jason Page @.***> wrote:

Absolutely. This is just to get things to crash. I won’t share and will delete as soon as possible.

Can you confirm how many sids this uses? I’d expect the crash to likely happen if saving as 3 or 4 sid only.

On Sun, 6 Nov 2022 at 10:41, Joe Cincotta @.***> wrote:

Pls don't share, this is for an unreleased demo. Maybe delete this comment once you download :)

megatune.zip https://github.com/jpage8580/GTUltra/files/9945617/megatune.zip

— Reply to this email directly, view it on GitHub https://github.com/jpage8580/GTUltra/issues/48#issuecomment-1304770679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGMDBUVWP4EY3UFFCRY3BLWG6DODANCNFSM6AAAAAARYLR6GU . You are receiving this because you commented.Message ID: @.***>

CINJ commented 1 year ago

sorry, was coding, let me check

CINJ commented 1 year ago

debug_0.zip See debug output

CINJ commented 1 year ago

The one time I managed to get export to work, the playback on Mega65 was clearly missing functionality, so I enabled sound effects and volume control to check and the crash occurs. I tried other permutations, but basically, it will always die if I try to export with any setting enabled.

jpage8580 commented 1 year ago

Thanks again. Will take a look as soon as I can

On Sun, Nov 6, 2022 at 11:12 AM Joe Cincotta @.***> wrote:

The one time I managed to get export to work, the playback on Mega65 was clearly missing functionality, so I enabled sound effects and volume control to check and the crash occurs. I tried other permutations, but basically, it will always die if I try to export with any setting enabled.

— Reply to this email directly, view it on GitHub https://github.com/jpage8580/GTUltra/issues/48#issuecomment-1304776158, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGMDBTIGO7ZIWBY6U33FTDWG6HBPANCNFSM6AAAAAARYLR6GU . You are receiving this because you commented.Message ID: @.***>

CINJ commented 1 year ago

Thanks @jpage8580. Pls see if you can lend a hand before the weekend. :)

jpage8580 commented 1 year ago

Try this one

https://www.dropbox.com/s/xbhw3uaz79sd12q/gtultra.exe?dl=0

On Sun, Nov 6, 2022 at 11:41 AM Joe Cincotta @.***> wrote:

Thanks @jpage8580 https://github.com/jpage8580. Pls see if you can lend a hand before the weekend. :)

— Reply to this email directly, view it on GitHub https://github.com/jpage8580/GTUltra/issues/48#issuecomment-1304780784, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGMDBVXOJAFMMBOHDQTAODWG6KPLANCNFSM6AAAAAARYLR6GU . You are receiving this because you were mentioned.Message ID: @.***>

CINJ commented 1 year ago

That fixed the bug! Thank you so much for turning that around so fast.