search

jpage8580 / GTUltra

GTUltra - Extensively modified GoatTracker Stereo (2.76) version. With many new features. See the GTUltra.PDF file for full details
GNU General Public License v2.0
88 stars 10 forks source link

Unable to save when there are no FF (stop) commands in the orderlist #53

Open acrouzet opened 1 year ago

jpage8580 commented 1 year ago

I'm guessing that there's two red ** at the top of at least one of the channels in the expanded order list. These are shown when the compressed size of that channel would be too big (greater than 255). As such, it will play in this view, but can not be saved or exported to SID, as these require valid compressed orderlist data. The maximum size allowed in the expanded view would compress to REPEAT 16, PATTERN nn multiple times.

On Mon, Dec 19, 2022 at 10:00 PM acrouzet @.***> wrote:

— Reply to this email directly, view it on GitHub https://github.com/jpage8580/GTUltra/issues/53, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGMDBQEJFICMC2W5C6BNJTWODLIPANCNFSM6AAAAAATD2MGL4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

acrouzet commented 1 year ago

Maybe you should put in some sort of text message warning when someone tries to save without markers in the expanded order list

jpage8580 commented 1 year ago

Will look into doing that.

It is all documented in the GTUltra.pdf

Section 46: Expanded OrderList - Compressed Size.

1.

When a .sng is saved or is exported, it is still done so in classic mode. This ensures that the data size is still as small as possible. 2.

In Expanded mode, is it possible to create order list data that is too large - the number of entries does not compress to under 256 bytes of data. 3.

The current compressed data size is shown at the top of the expanded orderlist view. In the case above, you can see: 1.

  Channel 00: **
  2.

  Channel 01: 33
  3.

  Channel 02: 38
  4.

The ** shows that the size of the channel is invalid (over 256 bytes). As such, it is not possible to swap back to the classic view - or the .sng to be saved or exported - until the data in this channel has been reduced to a valid size.

On Tue, 20 Dec 2022 at 21:11, acrouzet @.***> wrote:

Maybe you should put in some sort of text message warning when someone tries to save without markers in the expanded order list

— Reply to this email directly, view it on GitHub https://github.com/jpage8580/GTUltra/issues/53#issuecomment-1360257063, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGMDBQ4YBRR6MMWZ6LB43DWOIOJ7ANCNFSM6AAAAAATD2MGL4 . You are receiving this because you commented.Message ID: @.***>