jpahullo
commented
1 year ago Thanks for the feedback.
If I understand it properly, this edge case should be considered into the current implementation of merging grades into the plugin. This plugin tries hard to cover all cases, also edge cases. But for sure there are lots uncovered.
I like the idea of having implemented the way of loading customized settings.
It would be very welcome to receive a PR for both: considering grades edge cases into the current implementation, and also the function into lib.php files. However, keep loading config.local.php for backwards compatibility.
Thanks!!!
El El jue, 31 ago 2023 a las 9:25, Alexander @.***> escribió:
A client is attempting to merge users with grades that reference activities that no longer exist. I understand this is a database issue but an option to skip over these grades (with an appropriate warning) could be useful.
This option could be implemented on the user selection screen or the plugin settings. Let us know what you think. If you are happy with this proposal, we can submit a pull request.
This relates to #189 https://github.com/jpahullo/moodle-tool_mergeusers/issues/189.
— Reply to this email directly, view it on GitHub https://github.com/jpahullo/moodle-tool_mergeusers/issues/255, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPUCKCL5H7EAU2FDANDDLTXYA35TANCNFSM6AAAAAA4FTV3MI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
A client is attempting to merge users with grades that reference activities that no longer exist. I understand this is a database issue but an option to skip over these grades (with an appropriate warning) could be useful.
This option could be implemented on the user selection screen or the plugin settings. Let us know what you think. If you are happy with this proposal, we can submit a pull request.
This relates to #189.