Open leonstr opened 1 month ago
Thanks @leonstr for detecting this with the added test on PR #274 for the issue #273.
It will be very good if you could also provide a patch for this. Then, I would analyse both PR together to provide a full solution to both issues.
Thanks a lot in advance,
Jordi
Thanks a lot @camrionnvmff for your feedback.
Your idea is already included in the patch of the other PR, since @leonstr put together the solution for two issues.
Once we can test the patch in detail, we will merge the PR.
However, float numbers must be prevented to pass to be compared against an id column and https://www.php.net/manual/en/function.is-numeric.php tells true when any number is passed (int and floats are accepted).
But you got the idea, yes.
Thanks for your time and feedback.
Jordi
Steps to reproduce issue
Expected results
The search results are displayed.
Actual results
Environment: Moodle 4.2.8+ (Build: 20240719) and tool_mergeusers 2024060300.