search

jpahullo / moodle-tool_mergeusers

Merge users script for Moodle
https://moodle.org/plugins/view.php?plugin=tool_mergeusers
22 stars 52 forks source link

Creation of dynamic property AssignSubmissionTableMerger::$duplicateddatamerger is deprecated #278

Open leonstr opened 2 months ago

leonstr commented 2 months ago

This issue is reported in #262. Contrary to this comment the message appears when debugging is not enabled.

Steps to reproduce issue

  1. Install plugin.
  2. As a site admin go to Site administration > Users > Accounts > Merge user accounts > Merge user accounts.

Expected results

No errors on the page and no errors in the error log.

Actual results

The following message appears at the top of the page (behind the navigation bar) and in the PHP error log:

Deprecated: Creation of dynamic property AssignSubmissionTableMerger::$duplicateddatamerger is deprecated in .../admin/tool/mergeusers/lib/table/assignsubmissiontablemerger.php on line 34

Environment

Moodle 4.4.2+ (Build: 20240823), PHP 8.3.4 and tool_mergeusers 2024060300.

leonstr commented 2 months ago

PR #279 with proposed fix.

timbahula-horizon commented 1 week ago

Experiencing the same problem, Moodle 4.5 (Build: 20241007), MySQL (8.0.39-0ubuntu0.20.04.1) and too_mergeusers 2024060300

jpahullo commented 1 week ago

Thanks @leonstr for the PR. It was merged right now.

Please, all those you reported this problem, could you try the latest master branch version? Put a reminder on the Moodle version you tried, please, just to confirm that now it works properly, without any problem.

With your ok, I will update Moodle Plugins directory, bumping up its the plugin version.

Jordi