jpakkane / capypdf

A fully color managed PDF generation library
Apache License 2.0
89 stars 4 forks source link

Library wheel requires Gtk4 #25

Closed doctormo closed 2 months ago

doctormo commented 3 months ago

When building the latest capypdf wheel, the mason build requires Gtk4 despite not needing any gtk4 for just the libraries.

I'm actually concerned about how pdfviewer et al aren't separated in the codebase, should we split them out into their own repositories and use a submodule so there's less possible confusion between the library and the applications that use it?

In Inkscape we do this for things like lib2geom which are still in-line, but use git submodules so they can have their own development life cycle and much fewer dependencies.

jpakkane commented 3 months ago

It should not "require" it as such. If GTK 4 is available it will build the devtool and if it is not, then it won't.

I this causes problems then I guess we can move devtools in a separate directory and add a build option whether to build devtools or not.

doctormo commented 3 months ago

There is a compatibility problem with older glibs and newer Gtk4's, I have PopOS based on Ubuntu 22.04, and have been doing gtk4 work with Inkscape so it's installed. Running ninja on the builddir causes a single G_APPLICATION_DEFAULT_FLAGS isn't defined error.

But this would happen if I wanted the gtk programs anyway. The real grumble is that I don't need the gtk programs.

jpakkane commented 3 months ago

Devtools should now be separated and only built if you explicitly configure them to.

jpakkane commented 2 months ago

GTK is no longer looked unless you expliclly ask for it so closing.

doctormo commented 2 months ago

Thanks Jussi :heart: