jpalardy / vim-slime

A vim plugin to give you some slime. (Emacs)
http://technotales.wordpress.com/2007/10/03/like-slime-for-vim/
MIT License
1.87k stars 227 forks source link

Add Wezterm support #362

Closed Strosel closed 1 year ago

Strosel commented 1 year ago

Wezterm is a terminal emulator with built-in multiplexing and since I wanted to use Vim-slime with it, I went ahead and added that support.

I actually did this a few months ago but forgot to make a PR, the plugin works as expected but its my first time messing about in vim-docs so I hope I didn't miss anything.

jpalardy commented 1 year ago

Hi @Strosel

Thanks for the PR ⬆️

A while back, there was another PR (#333) that ended up not being merged. At the time, I saw the explosion of different targets I didn't support myself as a liability.

I ended up trying to extract "core vim-slime" from its support for targets -- https://github.com/jpalardy/vim-slime-ext-plugins

I know @Klafyvel ended up writing support for wezterm against it: https://github.com/Klafyvel/vim-slime-ext-wezterm

I'm not sure what @uncomfyhalomacro ended up doing 🤔

That being said, and vim-slime-ext-plugins being 90% done (but not DONE done), I'm willing to consider this PR.

Maybe you can integrate ideas from the other PRs (if needed), or coordinate with the people mentioned above. If it's working for all of you — I'll merge it in.

Let me know.

Klafyvel commented 1 year ago

Hi! Yes, I use vim-slime-ext-plugins and the wezterm plugin I wrote on a daily basis. You can take some code from it to adapt here, like for choosing the target. You might be interested in bringing an improvement using

wezterm cli list-clients --format json

rather than the wezterm cli list-clients command I used.

jpalardy commented 1 year ago

Hi @Strosel , @Klafyvel

I think I'm ready to merge this in. Any more changes we want to make?

Strosel commented 1 year ago

No more changes on my end

Klafyvel commented 1 year ago

I haven't tested it as I run on vim-slime-ext, but I see nothing shocking here. :)

jpalardy commented 1 year ago

Thanks @albheim ^