search

jpalardy / vim-slime

A vim plugin to give you some slime. (Emacs)
http://technotales.wordpress.com/2007/10/03/like-slime-for-vim/
MIT License
1.83k stars 223 forks source link

Fix the behavior of g:slime_python_ipython #386

Closed Henderake closed 11 months ago

Henderake commented 11 months ago

The g:slime_python_ipython functionality is intended to be deactivated when its value is set to 0. However, an oversight in the _EscapeText_python function currently ignores this value, which results in the feature remaining enabled even when the flag is set to 0. This pull request rectifies this issue by incorporating the necessary check for this value.

jpalardy commented 11 months ago

Hi @Henderake

Good point, as it stands right now this is misleading 😬

At worse, it doesn't hurt to be explicit.

Thanks for the patch 🎉