search

jpalardy / vim-slime

A vim plugin to give you some slime. (Emacs)
http://technotales.wordpress.com/2007/10/03/like-slime-for-vim/
MIT License
1.83k stars 223 forks source link

bracketed paste for zellij #394

Closed ctorney closed 9 months ago

ctorney commented 9 months ago

potential fix for #379 based on the suggestion from the zellij dev here. This appears to work but maybe there's a better zellij-based solution on the way

jpalardy commented 9 months ago

Hi @ctorney

Thanks for the PR 👍 — I commented on the string generation.

maybe there's a better zellij-based solution on the way

Did you want to give this more time?

ctorney commented 9 months ago

Hi @jpalardy

Did you want to give this more time?

I can't see another solution in the pipeline looking at the zellij repo @sourproton - any thoughts on this?

sourproton commented 9 months ago

Hi @ctorney

I like this solution a lot. I'm illiterate in vimscript and wasn't able to come to this solution myself.

Despite the solution being different from the other targets (i.e. for the others, their cli commands handle the bracket pasting, whereas for zellij, the string would be manipulated by vim-slime before being sent), I don't see it as a problem, and I too don't see this being addressed by zellij in the near future.

Even if zellij implements bracketed paste, I think it's worth it to continue with the PR now and merge it as an indefinite temporary solution. It will be very simple to modify vim-slime back to use zellij's cli bracketed paste flags once they exist.

jpalardy commented 9 months ago

looking good 🚀

I think (short of something changing on the zellij's side) that this is a good solution — it won't cap the size of the content you're trying to send over.

thank you both 👍