Refactor: Configuration Lookup - Githubissues

jpalardy / vim-slime

A vim plugin to give you some slime. (Emacs)

http://technotales.wordpress.com/2007/10/03/like-slime-for-vim/

MIT License

1.9k stars 227 forks source link

Refactor: Configuration Lookup #397

Closed jpalardy closed 1 year ago

jpalardy commented 1 year ago

Previously, there was a lot of redundant code to perform configuration lookup.

The logic remains the same, but is now explicitly done in slime#config#resolve as:

use b: (buffer) config, if it exists
use g: (global) config, if it exists
fallback to defaults — now contained in g:slime_config_defaults
echoerr if no default exists

Discussion

logic is centralized
handling is consistent
- some values did not have b:-level overrides
- some values were evaluated once (at load time) and cached
defaults are centralized
ftplugins can leverage same mechanism for defaults/lookup (see below)