search

jpalardy / vim-slime

A vim plugin to give you some slime. (Emacs)
http://technotales.wordpress.com/2007/10/03/like-slime-for-vim/
MIT License
1.83k stars 223 forks source link

fix: check that a terminal buffer is not hidden #421

Closed jmbuhr closed 3 months ago

jmbuhr commented 3 months ago

before attempting to use it as a channel. Otherwise getbufvar fails.

See https://github.com/jpalardy/vim-slime/issues/420

jpalardy commented 3 months ago

@jam1015 ^

jam1015 commented 3 months ago

Hi I just tested this like I did for my original PRs; with nvim --clean -u ./minimal.lua where minimal.lua was a minimal config file that loaded this plugin, and I fooled around with opening and closing terminals, and sending text to them.

This code doesn't break the plugin on that level of testing so I recommend merging it.

This has alerted me to other corner cases where non-standard buffers cause problems though, especially with SlimeClearChannel and I'm working out what those are and on fixes.

jpalardy commented 3 months ago

Thanks for the PR 👍