When on Windows, check for cmd.exe

jpalardy / vim-slime

A vim plugin to give you some slime. (Emacs)

http://technotales.wordpress.com/2007/10/03/like-slime-for-vim/

MIT License

1.83k stars 223 forks source link

When on Windows, check for cmd.exe #426

Closed djhaskin987 closed 2 months ago

djhaskin987 commented 3 months ago

Neovim + slime gets tripped up on Windows when using conemu as the target. Neovim sets the shell slightly different, and the quotes don't work the same.

This PR fixes the problem.

jpalardy commented 3 months ago

hi @djhaskin987

Thanks for the PR, I added a few questions inline

djhaskin987 commented 3 months ago

So, summary for this evening:

writefile worked, I added it.
In order to ensure I didn't mess up all the line endings in the repo while working on Windows I added a .gitattributes file.
Left the if/then around CMD and escaped args unchanged.

jpalardy commented 3 months ago

I'm not sold on the .gitattributes file, let's remove it for now.

The rest looks good 👍

djhaskin987 commented 2 months ago

OK, will do tonight :)

djhaskin987 commented 2 months ago

Sorry I didn't remove the attributes file I forgot.

jpalardy commented 2 months ago

don't worry about it 👍

I kept your commits in