search

jpalmieri / zendesk-progress-bar

A progress bar which shows the number of tickets the current Zendesk agent has solved
https://www.zendesk.com/apps/solved-tickets-progress-bar/
2 stars 3 forks source link

Cleanup round 2 #5

Closed jpalmieri closed 9 years ago

jpalmieri commented 9 years ago

Clean 'er up to be submitted to the app marketplace.

I went by this guide: https://support.zendesk.com/hc/en-us/articles/204578883

Also added a feature: random congrats gifs

@PolRod if you have a sec to look, awesome. If not, all good.

PolRod commented 9 years ago

Will having all those gifs affect the load times of the app? If not, looks good to me!

jpalmieri commented 9 years ago

It probably will...but maybe they'll be cached after the app is loaded once? I'll investigate further.

Regardless, it's probably better to only have them load on the congrats view; I'll add that change.

jpalmieri commented 9 years ago

@PolRod FYI: it actually won't let me upload the app to ZD. The max size is 7mb :disappointed:

jpalmieri commented 9 years ago

@PolRod do you think this works? I guess it's ultimately up to the ZD gods

jpalmieri commented 9 years ago

@PolRod it does affect the load time of the app, but only when it's in congrats mode, so I guess the user could change their goal if they didn't want to see it. Maybe a future version could use a "don't show this again" checkbox or something, which was stored in localStorage as well.

Also, I think I'm going to open a personal storage facility called localStorage

PolRod commented 9 years ago

I think it looks good! I like the localStorage solution to the extra loading and the localStorage idea. VEry locally sourced.