jpanther / dectorio

Dectorio is a large mod that adds decorative elements to Factorio.
https://mods.factorio.com/mod/Dectorio
GNU General Public License v3.0
23 stars 17 forks source link

Add *actual* shallow waterfill #235

Open chayleaf opened 1 year ago

chayleaf commented 1 year ago

Previously, only normal and deep water were supported (normal water was mistakenly called "shallow").

Since there are more than 4 valid states now (waterfill off, waterfill on, deep waterfill on, normal waterfill on), I changed waterfill to have 4 checkboxes instead of a checkbox and a dropdown. This means any people who update the mod will have the setting reset, as Factorio doesn't support mod setting migrations.

I could switch it to just 3 checkboxes instead (enable shallow/normal/deep waterfill) instead of 4 (enable waterfill + enable shallow/normal/deep waterfill). Additionally, perhaps "regular" would be better than "normal", I don't know.

I only know Russian, English and Japanese, so I did the translation changes with the help of DeepL. I did my best to make sure it's correct, but I may have made some mistakes.

For most languages, I didn't write a description for the new settings as I have no confidence in getting that right.

Also, is there a reason you only allow some waterfill with Alien Biomes enabled?