jpanther / lynx

A simple links theme for Hugo built with Tailwind CSS.
https://jpanther.github.io/lynx/
MIT License
354 stars 121 forks source link

Add Credly #20

Closed rwehe closed 2 years ago

rwehe commented 2 years ago

Credly shows digital credentials It would be nice to have in the main template https://info.credly.com/

netlify[bot] commented 2 years ago

Deploy Preview for hugo-lynx ready!

Name Link
Latest commit ddfcd60c055b7914c42b8d54039257b728f5bb0f
Latest deploy log https://app.netlify.com/sites/hugo-lynx/deploys/631817d70872310008d974e6
Deploy Preview https://deploy-preview-20--hugo-lynx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jpanther commented 2 years ago

Thanks for the suggestion, however the icons in Lynx come from FontAwesome and the SVG assets you have provided look like a full logo rather than an icon. Please update your PR with assets that are in keeping with the overall design of the theme.

rwehe commented 2 years ago

Looks like there’s an open request for the icon… https://github.com/FortAwesome/Font-Awesome/issues/15734

No other possibilities to implement this without an official Font Awesome update or Pro Acct to make one?

jpanther commented 2 years ago

Given there's not official FontAwesome one, I'm happy to look at other options if you can find an SVG that is in keeping with the existing icons in the theme.

rwehe commented 2 years ago

first attempt at normalizing it to look more like the theme https://github.com/rwehe/lynx/blob/dev/assets/icons/credly.svg They don't really have a block logo like the other ones in the icons folder so I think it's going to have to be the entire name as the logo

jpanther commented 2 years ago

I think it's going to have to be the entire name as the logo

Thanks, however that is still not in keeping with the theme. It's obviously fine for you to use this type of logo in your own project but I don't wish to include it in the theme package as it will disrupt the overall design language. One of the reasons for using FontAwesome for all the current assets is to keep a consistent design that is simple and easy for people to use.

rwehe commented 2 years ago

PR declined due to logo incompatibility