jpanther / lynx

A simple links theme for Hugo built with Tailwind CSS.
https://jpanther.github.io/lynx/
MIT License
349 stars 117 forks source link

Ad block lists removing links/buttons #45

Closed tarper24 closed 1 year ago

tarper24 commented 1 year ago

What happened?

When using lists like Fanboy's Social Blocking List or Fanboy's Annoyance List, some buttons will be filtered out, such as Facebook, Instagram, Tumblr, Twitter, YouTube.

I made an attempt/example of fixing this over at https://github.com/tarper24/lynx/tree/fix/fanboy-blocks. I changed the css class names for the links to be base64 encoded in that fix and made a helper lookup function for Hugo to convert to that encoded form. I'm opening this issue to bring the conversation forward to explore less messy solutions.

Expected

image

Actual

image

Theme version

v1.2.4

Hugo version

v0.109.0+extended

What browsers are you seeing the problem on?

Chrome

Relevant Hugo log output

No response

jpanther commented 1 year ago

Thanks for raising this issue, @tarper24. I do wonder if there is a neat way to avoid this problem, although it does beg the question about how much of an issue it really is. If people are blocking these items it's likely they're not using those networks to begin with, and so why would they ever click on the link in the first place?

At the end of the day people are choosing to block this and you can never completely predict every scenario that might come up on end user devices.

tarper24 commented 1 year ago

I think I had started using them to remove the "Share to X" buttons and Facebook like counters. Sites like link tree have their own workarounds for it already.

I haven't been using those lists personally since creating this issue, and haven't really noticed anything annoying to me, so it's likely my internet landscape is different not and doesn't need that so much

skhg commented 1 year ago

I had the same problem. My LinkedIn button was hidden on iOS Safari by 1Blocker. The relevant rule is Hide Element .link-linkedin in the "Block Widgets" category.

I got around it by creating a custom link type mynamecv with the text LinkedIn, icon linkedin and a custom css rule to match the LinkedIn background colour. Works fine now.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had any recent activity. If you are still experiencing this issue, please review the issue history and add a reply with any requested and/or additional information in order to keep the issue open. This issue will automactically close in 14 days if no further activity occurs.