search

jpanther / lynx

A simple links theme for Hugo built with Tailwind CSS.
https://jpanther.github.io/lynx/
MIT License
354 stars 121 forks source link

Add alternative text to author image #8

Closed stphnwlsh closed 2 years ago

stphnwlsh commented 2 years ago

Getting an accessibilty error on https://wave.webaim.org/report#/stphnwlsh.github.io for missing alt text on the image. This just adds the ability to add alternative text to the theme

stphnwlsh commented 2 years ago

@jpanther any thoughts on this PR? Just trying to close out my open ones. If you don't want it, I'm more than happy to close it.

jpanther commented 2 years ago

Thanks for reminding me about this one and apologies for not responding sooner. I did miss adding the alt text to this image but I wonder if having it as a separate configuration parameter is necessary? Could it not just use the author's name as the alt value?

stphnwlsh commented 2 years ago

Thanks for reminding me about this one and apologies for not responding sooner. I did miss adding the alt text to this image but I wonder if having it as a separate configuration parameter is necessary? Could it not just use the author's name as the alt value?

That's a fair call, just thought I'd give people the option but will change it back.

stphnwlsh commented 2 years ago

Okay reverted to just add the name as the alternative text. Also no need to apologise. I'm the one randomly contributing to your work

jpanther commented 2 years ago

Thanks, I'll merge this change in!