Antialias and a couple of comments

jpardogo / GoogleProgressBar

Android library to display progress like google does in some of his services.

Apache License 2.0

1.3k stars 271 forks source link

Antialias and a couple of comments #2

Closed romainpiel closed 10 years ago

romainpiel commented 10 years ago

Hey,

Good job mate for this library! A couple of comments there:

you should set the antialias to the paints, I've tried and it looks better
I'm not sure if inheriting from ProgressBar is a good idea. You are doing some extra work in your super.onDraw(canvas) I would actually clone the code from ProgressBar, remove what I don't need and set that as a base class for my custom progress bars.

Good idea anyway!

jpardogo commented 10 years ago

Thanks good idea both of them. It's true I've been a bit lazy calling super. As soon as I find some spare time I do it, commit and I comment back here.

romainpiel commented 10 years ago

Cool, I'm moving your code to a custom drawable it makes more sense. Will send a pull request later on.

jpardogo commented 10 years ago

Solved (9e16410839dd189d1e91d8b5ac3ba72b818750cc)