Fix visual problem and add new style

jpardogo / GoogleProgressBar

Android library to display progress like google does in some of his services.

Apache License 2.0

1.3k stars 271 forks source link

Fix visual problem and add new style #20

Closed MewX closed 9 years ago

MewX commented 9 years ago

The bug shows like this in low resolution screen:

device-2015-01-23-203704

I fix it by drawing twice, which likes adding it a "thickness" attribute. It's the easiest way to fix, I guess because of the transition from "dp" to "px". And I've tried to draw only once by adding 1 or 0.5f on "mHalf", problem still exists.

Here is the performance after drawing twice: device-2015-01-23-203740

MewX commented 9 years ago

movie

Added this new style from "Chrome doodle-notifier".

jpardogo commented 9 years ago

Thank you very much for the PR. I am a bit busy at the moment. I will take a look asap.

jpardogo commented 9 years ago

Please, review my comments so we can continue and merge...If you don't have time let me know I will do it.

MewX commented 9 years ago

Plus, should use getSupportActionBar() instead of getActionBar(). I fix this in the latest commit.

jpardogo commented 9 years ago

Merged into dev a1de603d3ea4a03a750eea15c4629c6489cc14bb