converted folding circles progress bar to folding circles drawable

jpardogo / GoogleProgressBar

Android library to display progress like google does in some of his services.

Apache License 2.0

1.3k stars 271 forks source link

converted folding circles progress bar to folding circles drawable #4

Closed romainpiel closed 10 years ago

romainpiel commented 10 years ago

So here is quite a big pull request, not sure if you agree with this one.

Here is the fixes it brings:

converted FoldingCirclesProgressBar to FoldingCircleDrawable so it can be reused in many other situations. plus it makes the use of it more clean from a progress bar (that's for #2)
cleaned up the code a bit. the new class is a bit lighter than the first one
the animation speed can be modified easily now with android:indeterminateDuration on the ProgressBar (that's for #1)

eveliotc commented 10 years ago

Pretty cool @RomainPiel @jpardogo I'm loving this

jpardogo commented 10 years ago

@RomainPiel, I agree with all fixes. You did a great job. I will merge the changes as soon as we decide what @eveliotc suggestions implement on this pull request. And which ones should be part of a new pull request.

romainpiel commented 10 years ago

yep I'm currently fixing the quick ones. I think the last one can be part of another PR.

romainpiel commented 10 years ago

FoldingCircleDrawable should be clean now

romainpiel commented 10 years ago

@eveliotc @jpardogo not sure I'll have time to play with this today or tomorrow. Feel free to play with it and correct the bits

romainpiel commented 10 years ago

One thing to remember before the rebase to master is to update the README as it changed a bit :)

jpardogo commented 10 years ago

@RomainPiel @eveliotc Great job! I will close the related issues as well. I think this is gonna be 1.0.0 so I will target it, push to maven and update README.