jpardogo / PagerSlidingTabStrip

An interactive indicator to navigate between the different pages of a ViewPager
2.19k stars 353 forks source link

Bug when the indicator line, underline and dividers are drawn #95

Closed jcdom closed 9 years ago

jcdom commented 9 years ago

I think there is an error when the indicator line, underline and dividers are drawn. The order in which draw is wrong.

Current order:

  1. Indicator line
  2. Underline
  3. Dividers

The problems are:

I consider correct this order:

  1. Dividers
  2. Underline
  3. Indicator line

Pager configuration in activity_main.xml:

<com.astuetz.PagerSlidingTabStrip
        android:id="@+id/tabs"
        android:layout_width="match_parent"
        android:layout_height="?attr/actionBarSize"
        android:background="?attr/colorPrimary"
        app:pstsUnderlineColor="#FF0000"
        app:pstsUnderlineHeight="6dp"
        app:pstsIndicatorHeight="6dp"
        app:pstsDividerWidth="6dp"
        app:pstsDividerColor="#0000FF"
        app:pstsTabPaddingLeftRight="10dp" />
jpardogo commented 9 years ago

Yeah that make sense

jpardogo commented 9 years ago

PR associate #96 has been merged in dev branch for next release