jparis / qrs-interact

Inactive - QRS Interact is a simple javascript library that allows users to send queries to the Qlik Sense Repository Service.
GNU General Public License v3.0
10 stars 7 forks source link

Bugs in UseCookie, UpdateVirtualProxyPrefix and generateBasePath #38

Closed goldbergjeffrey closed 7 years ago

goldbergjeffrey commented 7 years ago
this.UseCookie = function (userCookie) {
        console.log(userCookie);
        requestDefaultParams.headers.Cookie = userCookie;
        delete requestDefaults.headers['X-Qlik-User'];  **This needs to be requestDefaultParams.headers***
        requestDefaults = request.defaults(requestDefaultParams);
    };
this.UpdateVirtualProxyPrefix = function (vProxyPrefix) {
        basePath = generateBasePath(hostname, portNumber, vProxyPrefix); **When using a virtual proxy prefix the portnumber is not used**
    }
return (newHost.startsWith('http') ? newHost : "https://" + newHost) +
            (port == "" ? "" : newVirtualProxy != "" ? "" : ":" + port) +
            (newVirtualProxy == "" ? "" : "/" + newVirtualProxy) + **An extra slash is being added here because it is added earlier**
            "/qrs";
jparis commented 7 years ago

can I close this @goldbergjeffrey ?

goldbergjeffrey commented 7 years ago

I think so...I haven't finished all the work on security for QMCUtils yet, but I think my needs are met.