jparkerweb / pixel-banner

🚩 Plugin for Obsidian that allows you to automatically add beautiful banner images to your notes using the Pexels API.
https://obsidian.md/plugins?search=Justin%20Parker
MIT License
16 stars 0 forks source link

Embed note would also show the banner; no banner in Readinig mode #14

Closed Moyf closed 6 days ago

Moyf commented 1 week ago

Tested in Snadbox vault, and found out those issues:

  1. If I embed another note in current note, the embeded block will also show the banner of current note:

for example:

in a.md:

![[b.md]]

a & b would both show the banners.

image

  1. When switching to reading view, banner will disappear:

image

jparkerweb commented 6 days ago

@Moyf please update the plugin 😀 Fixed version is 1.3.1

Moyf commented 6 days ago

@Moyf please update the plugin 😀 Fixed version is 1.3.1

Updated and it works! Great, Thanks!! 🥳

Moyf commented 6 days ago

@Moyf please update the plugin 😀 Fixed version is 1.3.1

After the update, the banner has become "sticky" (it will always be displayed). I prefer the previous style, where it would move to the top when scrolling. Is there any way to change it back? Or could this be made an optional setting?

e303a847-66f3-4572-ad84-c96a7b155118

I actually prefer the whole previous old style - not full width, with some radius, haha. Perhaps we could consider offering both classic and modern options?


Additionally, could the "render embedded note banner" also be an option? Sometimes we prefer the embedded block to be simpler. Although this can be achieved through CSS classes, I don't think it's a major issue. ; )