search

jparkerweb / pixel-banner

🚩 Plugin for Obsidian that allows you to automatically add beautiful banner images to your notes from various sources.
https://www.equilllabs.com/projects/pixel-banner.html
MIT License
48 stars 0 forks source link

❓ Multiple Keywords for Folder Images and Pin/Refresh Always Showing #61

Closed Moyf closed 1 week ago

Moyf commented 1 week ago

Hello! It appears that this input box does not support multiple keywords at the moment. When more than one word is entered, it becomes invalid and fallback to default images 🤔 image

By the way, I have a small suggestion: if a note does not have its banner, should we consider hiding these icons as well? image

jparkerweb commented 1 week ago

@Moyf for your 1st / main point the Folder images do support multiple keywords. A random word from the comma delimited list is selected and an image matching that search term is returned from one of your Image API's (based on your settings). If you have multiple keywords and multiple APIs setup you could run into a scenario where a keyword doesn't find an image on a certain API, at which point some other random image will be displayed.

Let me know if that doesn't make sense. Please try it again. I can provide an animated gif to show you what I mean if needed. Thanks for being a power user :)

jparkerweb commented 1 week ago

@Moyf for your second point, I don't see the Pin or Refresh icon on any of my notes that don't have a banner applied. Can you reproduce this in an example vault and share with me?

Thanks.

Moyf commented 1 week ago

@Moyf for your 1st / main point the Folder images do support multiple keywords. A random word from the comma delimited list is selected and an image matching that search term is returned from one of your Image API's (based on your settings). If you have multiple keywords and multiple APIs setup you could run into a scenario where a keyword doesn't find an image on a certain API, at which point some other random image will be displayed.

Let me know if that doesn't make sense. Please try it again. I can provide an animated gif to show you what I mean if needed. Thanks for being a power user :)

Oh, after several times of refresh, I see the effect! It seems it was a false alarm, let's ignore this! Thank you for your patience and response!

Regarding the second issue, I think I might have encountered an edge case at that time: I entered the banner metadata but cleared it, so the banner disappeared while the button remained: image

In fact, reopening this page wouldn't cause any issues, so I think this doesn't need to be taken seriously either~