jparkerweb / pixel-banner

🚩 Plugin for Obsidian that allows you to automatically add beautiful banner images to your notes from various sources.
https://obsidian.md/plugins?search=Pixel%20Banner
MIT License
46 stars 0 forks source link

❓ Banner Image incorrectly Added? #67

Open Moyf opened 3 days ago

Moyf commented 3 days ago

image

The source md:

This is an attachment:
! [[obsidian-sync-vault-v0.4.0.zip]]

And this is an image:

! [[2024-11-19-img-241119_160901.jpg]]

And it seems that the banner was added incorrectly.

(The note has the Folder Banner configuration applied.)

jparkerweb commented 3 days ago

@Moyf What do you mean the banner was added incorrectly? Is it that the content is overlaying your banner? Without seeing the setting you have for the Folder Banner I can't be sure of what you are seeing.

Do you need to adjust the content-start and banner-height field values?

Happy to help, just need some more info as I'm not sure what you are asking / reporting.

Thanks :)

Moyf commented 2 days ago

@Moyf What do you mean the banner was added incorrectly?

Ah, I see. It seems that my previous description was too brief, sorry > < I will provide a more detailed explanation.

This is an image from the my daily note: image

Checking the Dev Tool can better reveal the structure— a banner is placed behind this image: image

The expected display should be only the image, without the banner behind it.

🤔 Perhaps this image is mistakenly identified as an "embedded note"?

By the way, the "embedded files" above it also have a similar issue, but it's not very noticeable because the space is small. image


In addition, this is my folder configuration: image

And my other notes don't have this issue, images are clean images: image

Once adding the folder in settings, issue appears: image

The Settings: image

jparkerweb commented 2 days ago

@Moyf

I am afraid I still don't understand the issue. From what I see the plugin is working as designed. Pixel Banner images always display "behind" content on the page (the element uses absolution positioning to achieve this). If you want your content (images, text, etc.) to start further down the page after the banner then you need to adjust the "content start" value.

Sorry if I am not fully understanding this issue. If this still isn't clear can you create an example vault, zip it up and attach to this issue so I can see your problem on my machine?

jparkerweb commented 2 days ago

here is an example note that has a "forest" banner applied via the Folder Images settings: Image

here are screenshots of that same note with different "content-start" values: Image

Image

Image

Moyf commented 1 day ago

Ah.. I see. Actually the "banner" in my demonstration screenshot is not the Note banner on top of my page - which works fine. It's behind each of my embedded images.

For example, if I insert 3 images in my note, I'll got 4 banners: one for the note, and 3 for each of the images. In your screenshot, the image you embedded is full width. I guess the banner was covered by the image. Can you try some "longer" images (portrait rather than landscape) and see what happens?

Today I'm on a business trip. When I come back, I will prepare a sample vault for you if it can't be reproduced. 😇

Moyf commented 1 day ago

Here is a record video, I hope it can explain the issue more clear: https://github.com/user-attachments/assets/148c2f94-73d0-4e92-b160-fea66ab03595

And this is the testing vault: Obsidian Sandbox for Banner.zip