search

jparyani / laverna-sandstorm

1 stars 0 forks source link

New version for Sandstorm #3

Closed JamborJan closed 8 years ago

JamborJan commented 8 years ago

Would it be possible to get the latest version packed for sandstorm? Especially tags and notebooks are useful features users are asking for. They are available in the latest version from the upstream repo.

Please let me know if I can support you and prepare a PR.

(FYI @germakoci)

ocdtrekkie commented 8 years ago

As a thought note, I'd say that if you can test the new version against Sandstorm, and prep a PR, that's probably an ideal way to not bog down the core Sandstorm devs with testing and deploying app updates. Even if there's things to fix that needs their help, it could save them some time.

JamborJan commented 8 years ago

Absolutely agree with you, that's why I asked. Will send a PR soon. Thx.

jparyani commented 8 years ago

I'd love a PR updating Laverna :)

Notebooks were intentionally removed at one point since they were causing problems (unfortunately I forget exactly what that problem was). I think the UI for it was somewhat broken, and it was hard/impossible to select notebooks.

I'm all for tags, and I'm ok with adding support for notebooks back in as long as it's all working.

germakoci commented 8 years ago

would love to test this with my group and give feedback on what works, since the latest version really looks nice for collaborative work.

JamborJan commented 8 years ago

Hey guys,

Short update. I was able to do some stuff, see https://github.com/JamborJan/laverna-sandstorm

It is still not working 100% out of the box but I think it's only cleanup work, the main points are:

If the weekend is as rainy as the weather forecast announced it I should have some time to do this. Otherwise it might take some more time.

Cheers

JamborJan commented 8 years ago

can be closed as there has been a new version: https://github.com/jparyani/laverna-sandstorm/commit/ee4eb99485c0a770ea3647cacbdd24d29ae13b91