search

jpatokal / mediawiki-gateway

Ruby framework for MediaWiki API manipulation
Other
133 stars 50 forks source link

Do not continue when enough contributions have been received #79

Closed sigmike closed 9 years ago

sigmike commented 9 years ago

When a limited number of contributions is requested, Mediawiki now sends a reply with the continue attributes, so the gateway keeps requesting contributions.

Now it stops when the count is reached.

blackwinter commented 9 years ago

Thanks for your report. I'll look into it when time allows.

blackwinter commented 9 years ago

I've merged your patch. Thank you for your contribution! Please let me know if you need this change in a published release right away.

For lack of test cases and/or suitable examples, I have not verified the behaviour myself beyond inspecting the code. I trust that it works the way you intended it to and doesn't break any existing functionality. (I guess, however, that result.take(count) is redundant now.)