jpatokal / mediawiki-gateway

Ruby framework for MediaWiki API manipulation
Other
133 stars 50 forks source link

Change the exception superclass to StandardError #85

Closed branliu0 closed 9 years ago

branliu0 commented 9 years ago

Changed the superclass of MediaWiki::Exception from ::Exception to ::StandardError.

It's best practice in Ruby to rescue StandardError instead of Exception. Exceptions that are not StandardErrors are reserved for things like Interrupts, out of memory errors, and so on. Normal Ruby code is supposed to use StandardErrors.

jpatokal commented 9 years ago

Merged, thank you!