missing attribution “© OpenStreetMap contributors”. on the (osm?) map?

[my-na-me]

Is there a missing attribution “© OpenStreetMap contributors” information on the (osm?) map for webpage: https://openflights.org/?

For additional information please see here: https://www.openstreetmap.org/copyright/en

[jpatokal]

Hmm, interesting, attribution is provided in the code (see below) but this doesn't appear to be rendering on the map:

Map tiles by CartoDB (CC BY 3.0), data by OSM (ODbL)

(from https://github.com/jpatokal/openflights/blob/master/openflights.js#L130)

It looks like the OpenLayers.Layer.XYZ object we're using may not support attributions. Pull requests to update this welcome :)

[my-na-me]

@jpatokal

Thanks for checking.

It looks like the OpenLayers.Layer.XYZ object we're using may not support attributions. Pull requests to update this welcome :)

Actually unfortunately i'm not a programmer & i can't tell anything about the OpenLayers.Layer.XYZ layer. I saw in meantime your project is added to a application list which lacking of proper attribution - wiki OpenStreetMap a long list of open and closed cases. Maybe you can find there any other (open source) application for which the attribution issue is already fixed and they did use similar technology and have a solution which you could just copy&paste to your project. :-)

[kmpoppe]

Hi @jpatokal and @my-na-me, I came here because another page that I want to write to because of missing attribution also uses OpenLayers.XYZ - a quick look at their website in the examples gives a way on how to add attribution:

http://dev.openlayers.org/examples/attribution.html

Please use this as a reference on how to create the attribution you need to give for your project. Thanks :-)

Kai

[matkoniecz]

You are using OpenStreetMap data without attribution.

You even got pull request that fixes this - you have not bothered to even review it.

[reedy]

Possibly worth some attribution on https://openflights.org/about in the Credits section too

[matkoniecz]

I hope that it is sign that something is moving forward!

As long as you use OSM data you are legally obligated to show license clearly visible to users who view OSM-derived map. And no, deeply buried mention on "about" page is not sufficient.

Please, see https://www.openstreetmap.org/copyright if in doubt

[kmpoppe]

They asked in the PR how they could test the attribution, rather where it would be displayed and I answered that, so my guess is they are working on this problem right now @matkoniecz

[reedy]

As long as you use OSM data you are legally obligated to show license clearly visible to users who view OSM-derived map. And no, deeply buried mention on "about" page is not sufficient.

Please note what I wrote:

Possibly worth some attribution on https://openflights.org/about in the Credits section too

"too" meaning "as well as" not "instead of"; other similar data sources, attributions are mentioned in a couple of places and given credit. If we're going to fix it, we might aswell get it done right.

And yeah, I'm going to hopefully test the PR later today.

Don't worry, I'm very much aware of the importance of attribution.

[reedy]

Ok, so this isn't deployed yet, but https://github.com/jpatokal/openflights/commit/b82c1443501a7f80eabb0cf356d5402c8b114a39 brings the controls back to the map...

Which fixes the basic issue that @jpatokal highlighted above.

Hmm, interesting, attribution is provided in the code (see below) but this doesn't appear to be rendering on the map:

Map tiles by CartoDB (CC BY 3.0), data by OSM (ODbL)

(from https://github.com/jpatokal/openflights/blob/master/openflights.js#L130)

It looks like the OpenLayers.Layer.XYZ object we're using may not support attributions. Pull requests to update this welcome :)

When Jani is around, hopefully they can deploy the update.

As per my comments at https://github.com/jpatokal/openflights/pull/1037/files#r1174599252 too, I'm not 100% sure where the attribution for OSM needs to go in these cases.

Does the one that says "data by OSM" actually resolve this in the broad sense?

I understand specific wording may be needed, as it differs from the PR at https://github.com/jpatokal/openflights/pull/1037/files

Possibly worth some attribution on https://openflights.org/about in the Credits section too

I still want to do something around this too.. So will have a look at that next...

[reedy]

Must've been some testing when I was playing around.. Looks like I still neeed to fix the positioning!

[reedy]

Window size related....

[reedy]

Now I just need to fix the location of the quicksearch and the qsmini... And probably the context map too for ease. They need to be more sticky to the map, rather than relative to the window as a whole...

[reedy]

This is now live...