jpaulm / drawfbp

Tool for Creating and Exploring Flow-Based Programming Diagram Hierarchies
http://www.jpaulmorrison.com/fbp/
146 stars 20 forks source link

Discrepancies between .drw XML schema and actual DrawFBP output #15

Closed ERnsTL closed 6 years ago

ERnsTL commented 6 years ago

Greetings, there are some observed differences / discrepancies between what is defined in the XML schema file for .drw files and what is actually output by DrawFBP.

Observations so far:

jpaulm commented 6 years ago

XML schema has been expanded to include subnetport[s] - has already been promoted to DrawFBP lib web pages...

@ernstl could you test this? One of the validation products doesn't seem to like the drawfbp_file document type... Thanks in advance!

ERnsTL commented 6 years ago

Thanks for adding the subnetports

The document and XSD validates:

I downloaded the .xsd XML schema and ran xmllint:

$ xmllint --schema drawfbp_file.xsd filelinefiltercount.drw --noout

filelinefiltercount.drw validates

Also tried the W3C online XML and XSD validator. Pasted an example .drw file and the .xsd files. Result:

But the schema reference URL seems to be wrong. It is xsi:noNamespaceSchemaLocation="https://github.com/jpaulm/drawfbp/blob/master/lib/drawfbp_file.xsd" but this URL leads to an HMTL page with the .xsd nicely formatted for human reading. The URL should be https://raw.githubusercontent.com/jpaulm/drawfbp/master/lib/drawfbp_file.xsd - this points to the received the plain/raw .xsd file itself.

This is the same URL you get when you click on "View raw" from this page.

Apart from that the new schema version looks OK.

I can check .drw files generated with the new DrawFBP version when it is on Maven.

ERnsTL commented 6 years ago

Just ran an updated diagram saved using v2.14.2 with subnetports through the W3C's XML validator again; the XML is well-formed and conforms to the XSD schema.

Should be fine now.

jpaulm commented 6 years ago

Closed with v2.14.2