search

jpauwels / pywebaudioplayer

https://pypi.org/project/pywebaudioplayer/
MIT License
10 stars 1 forks source link

Trackswitch image caching fix #4

Closed sebastianrosenzweig closed 4 years ago

sebastianrosenzweig commented 4 years ago

As discussed in issue #2

sebastianrosenzweig commented 4 years ago

Since this is my first pull request ever I struggled a bit, but now, I think, I managed to incorporate your changes...^^:D

jpauwels commented 4 years ago

Great, that looks perfect indeed. Congratulations on your first PR , may many more follow.

I ended up doing some work myself and ended up applying your patch locally, so don't worry if it doesn't look merged in the GitHub interface. I've split off the code to use specifically for Jupyter Notebook in a separate file, so you should now do import pywebaudioplayer.notebook as pwa instead of import pywebaudioplayer as pwa, but otherwise the rest remains the same. Have a look at the updated example-notebook.ipynb if you like.

For now there's a lot of duplicated code due in the notebook.py file, which I'll resolve over time, but this way I can experiment a bit more without breaking everything. I've also released the reorganised module with your patch as version 0.0.5 on PyPI, so you can pip install [-U] the latest version.