jpaver / opengametools

A set of open c++ game development tools that are lightweight, easy-to-integrate and free to use. Currently hosting a magicavoxel .vox full scene loader.
MIT License
375 stars 36 forks source link

ogt_vox: fix buffer overrun when nTRN node names are longer than 64 bytes #46

Closed jpaver closed 1 year ago

jpaver commented 1 year ago

Fixes issue https://github.com/jpaver/opengametools/issues/45

jpaver commented 1 year ago

Hey @mgerhardy thanks for filing that issue. I did manage to get a repro that hits the same assert you mentioned in the issue, and this commit fixes it for me. Could you verify that you're seeing no issues after this commit too? Thanks!

mgerhardy commented 1 year ago

Works for me, too - thanks for the fast fix