search

jpbarraca / pynrf24

Python port of the RF24 library for NRF24L01+ radios.
GNU General Public License v2.0
152 stars 84 forks source link

Error in setDataRate #20

Closed dquadros closed 3 years ago

dquadros commented 8 years ago

Should be setup &= ~(NRF24.RF_DR_LOW | NRF24.RF_DR_HIGH) instead of setup &= (~NRF24.RF_DR_LOW | NRF24.RF_DR_HIGH) This error messes up the default rate of 1Mbps (radio will be programmed to 2Mbps instead)

n0skill commented 8 years ago

I just sent a pull request to fix the issue, it should be fixed soon.

dquadros commented 8 years ago

I did a fork, made a few changes and added comments to the code. Some of the changes are more about the way I code and probably should not be moved back to the master. So far I'm using the code in a very specific environment, latter on I hope to make more abrangent tests.

Daniel

Enviado do Yahoo Mail no Android

De:"Noskill" notifications@github.com Data:8:30 seg, 12 de out de AM Assunto:Re: [pynrf24] Error in setDataRate (#20)

I just sent a pull request to fix the issue, it should be fixed soon.

— Reply to this email directly or view it on GitHub.

n0skill commented 8 years ago

Okay then, I'll just close my request. Thanks for letting me know :)

jpbarraca commented 8 years ago

Some of the things you are changing really make sense. I will try to update my version accordingly. In alternative, send a pull request.