jpbruinsslot / slack-term

Slack client for your terminal
MIT License
6.42k stars 226 forks source link

Support for 16 colors #86

Open prabhu-madanagopal opened 6 years ago

prabhu-madanagopal commented 6 years ago

Hi, Thanks for this great cli for slack!

I use solorized theme on iTerm. The channel highlight on color doesn't work with default color as fg and default color as bg. If I could replace default with my actual default color which is brblue (fg) and brblack (bg) then it would work. But slack-term supports only 8 colors. Is there a way to support 16 colors at least from this list (look for TERMCOL): http://ethanschoonover.com/solarized

Looking forward to the colorize enhancement on the unique names and possibly an option to colorize the corresponding text with the same color! We love colors on terminal!

Thanks, Prabhu

jpbruinsslot commented 6 years ago

Hey thanks, I'm glad that you like it! I also love colors on the terminal but I'm bounded by termui which hasn't got any support for more than 8 colors. There is however a pull request that would create support of 256 colors. However, termui hasn't seen any substantial changes in the last year, so that pull request isn't going to be merged any time soon. I've already forked termui to solve some problems, and if I would merge the pull request for 256 color support and implement that, I recon that the next issue here will be asking for adding support for 24-bit colors.

That in turn will not happen because termbox-go, the library on which termui is based, has made it clear that it won't support 24-bit colors. So, in order to get more colors in slack-term would mean I need to base it on something different than termui. I'm looking into that, but that is going to be a bit more involved.

jpbruinsslot commented 5 years ago

256 color support has been merged into termui (https://github.com/gizak/termui/pull/82)

ezracelli commented 4 years ago

Ik this is an old issue -- but has there been any progress on this? Highlighted channel/thread names are not visible (white on white with dark color theme) and one unlucky person's name is invisible (black on black) with config setting .theme.message.name set to colorize

image

image