search

jpbruyere / vke.net

Vulkan .net library
MIT License
13 stars 3 forks source link

GetStreamFromPath(string) assumes assembly will not have periods in it #9

Closed Shawdooow closed 2 years ago

Shawdooow commented 2 years ago

I have an assembly with embedded .spv shaders with a name like engine.module and this function appears to only check for an assembly called engine and gives up once it fails to find it.

https://github.com/jpbruyere/vke.net/blob/0d2872f7c5791dcc6860227dbb34299f2da4340a/vke/src/Utils.cs#L45

jpbruyere commented 2 years ago

I've pushed a new beta to nuget with the modification to allow those assembly names with 2 parts. (version 0.2.3-beta). Be aware that from 0.2.2-beta, vke minimal framework is netcoreapp3.0. I hope this will not be a problem. Tell me if netstandard support would be better for you.

Shawdooow commented 2 years ago

Thanks for the fast reply and quick fix. Framework version shouldn't matter for my projects as I am on net6.0-windows.

jpbruyere commented 2 years ago

Ok, thanks, feel free to send screenshots or share your feeling and experience with this lib.

Shawdooow commented 2 years ago

Do you have a slack / discord server?