search

jpchnz / vidaas

Automatically exported from code.google.com/p/vidaas
0 stars 0 forks source link

Incorrectly named variable #107

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I am raising this to hopefully avoid confusion in the future. 

There is a boolean in uk.ac.ox.oucs.vidaas.session.Authenticator called 

loginAttemptedAndSuccessful

The code has been written to have this false if the login has been attempted 
and is successful, true otherwise. Clearly this is incorrect and will likely 
confuse future developers. I have added a comment about this to the code, but 
the name should be changed at some stage to avoid this confusion.

Original issue reported on code.google.com by thest...@gmail.com on 3 Jan 2012 at 9:53

GoogleCodeExporter commented 9 years ago 
Changed the values for the variable to avoid confusion

Original comment by aassif.a...@googlemail.com on 20 Jan 2012 at 1:08