jpcima / ADLplug

FM Chip Synthesizer — OPL & OPN — VST/LV2/Standalone
Boost Software License 1.0
425 stars 22 forks source link

"fatal: reference is not a tree" when cloning with submodules #2

Closed sneakernets closed 6 years ago

sneakernets commented 6 years ago

I'm trying to clone this and I can't get off the ground due to the submodules not being in sync with the project. I've only seen errors like this once or twice in my life and it's usually due to something in the submodule commits not being pushed.

jpcima commented 6 years ago

Good catch. I have screwed up here, by making personal commits in the JUCE submodule. I have added to JUCE some fixes which have since been accepted in their develop branch, and in top of that I have added the LV2 support commits which they don't yet have as an upstream feature.

For now, I give you an archive of current source of JUCE which I have. JUCE.tar.gz

Please note that ADLplug is not yet very useful software. While it is able to play, it cannot yet load instruments or do dynamic control, just the default bank will play. I have put the development on hold until dynamic edition of instruments becomes possible, which @Wohlstand has self-assigned. I should checkout with him about status of this, and possibly continue this work myself.

In this project, I prefer not to introduce crap workarounds I am going to rework later on. While this is on hold, I have prefered to enhance adljack instead for more dynamic control features.

sneakernets commented 6 years ago

Alright - a friend of mine wanted to use my patches in her music project and I've been trying to find a solution with what is available right now. The only issue is that she has a deadline and I'm not sure if I can come up with something in time. Would adljack be a solution?

jpcima commented 6 years ago

If you want the most basic support of banks, I may be able to come up with a super shitty 10 minute solution potentially. I would isolate this one in a separate branch.

What os do you want this made for? ADLjack has support for MIDI virtual port, including on Windows. But if you will want to reroute the audio output, I'm not sure at all there will be a solution to do that.

sneakernets commented 6 years ago

oh! Mac OS 10.12 is what my friend uses, and her DAW only accepts VST2 (so no AU or VST3). I happen to use Mac OS as well so I can use this too.

jpcima commented 6 years ago

alright let's do it

jpcima commented 6 years ago

Having a lot of trouble pushing to github right now. Dunno what is going on.

Try this: ADLplug-mac+bankloader.tar.gz

I have never tested mac, I'm not even sure the directory structure of the VST bundle is completely right. But, you're going to tell me this.

If I got this right, loading banks must now be possible.

sneakernets commented 6 years ago

I just gave her that file and I will let you know. I'm currently at work on a Windows machine so I can't test it myself (boo)

sneakernets commented 6 years ago

Alright it works, but there doesn't seem to be a way to change the instrument from the VST itself. No host-automatable parameters that we can see, so I assume it's listening for MIDI program changes? I know that sounds obvious but Propellerhead Reason is one of the most frustrating DAWs to use when it comes to stuff like VSTs,

sneakernets commented 6 years ago

And let me clarify... by instrument I mean the instrument number changes (from Trumpet to Trumbone for example) and not the FM parameters. that would be too complicated I think...

jpcima commented 6 years ago

Parameters are not done, and none of the sliders or knobs are going to change a thing. It will respond to program and bank changes by midi, because libADLMIDI supports that by itself. But from the UI, there is no way to do that right now. The UI controls which respond are ones which are not linked to parameters: the chip count, and emulator.

sneakernets commented 6 years ago

Aaah okay thank you. I figured that was the case. Still it's amazing a $400 DAW can't send midi commands to VSTi other than the simple note events that even a keyboard from the 80s can do.

jpcima commented 6 years ago

It's fixed, now ADLplug has all the parts needed to build available from the repository. I close this issue.