A few errors/warnings

[trebmuh]

A few errors/warnings reported by Lintian while building on a Debian Stretch (LZK-2). I didn't investigate these, only reporting these here to share the knowledge.

Note that:

• "P" means "pedantic"
• "E" means error

P: adlplug source: source-contains-prebuilt-javascript-object thirdparty/fmt/doc/_static/bootstrap.min.js
N: 
N:    The source tarball contains a prebuilt (minified) JavaScript object.
N:    They are usually left by mistake when generating the tarball by not
N:    cleaning the source directory first. You may want to report this as an
N:    upstream bug, in case there is no sign that this was intended.
N:    
N:    Severity: pedantic, Certainty: possible
N:    
N:    Check: cruft, Type: source

E: adlplug source: source-is-missing thirdparty/fmt/doc/_static/bootstrap.min.js
N: 
N:    The source of the following file is missing. Lintian checked a few
N:    possible paths to find the source, and did not find it.
N:    
N:    Please repack your package to include the source or add it to
N:    "debian/missing-sources" directory.
N:    
N:    If this is a false-positive, please report a bug against Lintian.
N:    
N:    Severity: serious, Certainty: possible
N:    
N:    Check: cruft, Type: source

P: adlplug source: source-contains-prebuilt-binary thirdparty/libADLMIDI/fm_banks/op3_files/2x2patch/bytecmp
N: 
N:    The source tarball contains a prebuilt ELF object. They are usually left
N:    by mistake when generating the tarball by not cleaning the source
N:    directory first. You may want to report this as an upstream bug, in case
N:    there is no sign that this was intended.
N:    
N:    Severity: pedantic, Certainty: certain
N:    
N:    Check: cruft, Type: source

P: adlplug source: source-contains-prebuilt-java-object thirdparty/JUCE/extras/Projucer/Source/BinaryData/gradle/gradle-wrapper.jar
N: 
N:    The source tarball contains a prebuilt Java class file. These are often
N:    included by mistake when developers generate a tarball without cleaning
N:    the source directory first. If there is no sign this was intended,
N:    consider reporting it as an upstream bug.
N:    
N:    Severity: pedantic, Certainty: possible
N:    
N:    Check: cruft, Type: source

Same issue with:

P: adlplug source: source-contains-prebuilt-java-object thirdparty/JUCE/examples/DemoRunner/Builds/Android/gradle/wrapper/gradle-wrapper.jar
P: adlplug source: source-contains-prebuilt-java-object thirdparty/JUCE/extras/AudioPerformanceTest/Builds/Android/gradle/wrapper/gradle-wrapper.jar
P: adlplug source: source-contains-prebuilt-java-object thirdparty/JUCE/extras/AudioPluginHost/Builds/Android/gradle/wrapper/gradle-wrapper.jar
P: adlplug source: source-contains-prebuilt-java-object thirdparty/JUCE/extras/NetworkGraphicsDemo/Builds/Android/gradle/wrapper/gradle-wrapper.jar

Note that this doesn't prevent to technically build and package the software. But this is the proper way of building a proper deb package.

[jpcima]

thirdparty/fmt

This is the project at https://github.com/fmtlib/fmt, it's more relevant to open an issue there as I don't do any significant development on this subproject myself beside the occasional contribution.

thirdparty/libADLMIDI

Definitely a problem here, it's needed to fix in libADLMIDI upstream. It's a leftover of a 2016 work tagged as "Another experiment with OP3-files".

thirdparty/JUCE

I have control on this personal fork of JUCE but I avoid to make a big cleanup which is going to deviate it too much from upstream, because I update it to upstream somewhat regularly and I'm not looking to introduce any conflicts.

However, as I manually produce the tarball for every release, I delete some unnecessary parts of JUCE which would occupy a significant space in the archive, and part of that is the extras folder from which the problem is arised.

Here specifically, Gradle is a utility specific to Android which doesn't serve me for any purpose.

[jpcima]

The error triggered by libADLMIDI has been resolved for a moment. For others, it's from external projects over which I don't have control, it's safe to ignore it or blacklist it. I close this issue, reopen if any need.