Closed ghost closed 5 years ago
Don't mind too much about makefiles, they have some issues, I will push some fixes later.
@trebmuh are you interested in reading the document? I have put a current copy online. http://jpcima.sdf1.org/software/documentation/ADLplug/manual/en/manual.html
@jpicma Thanks, I pushed a commit with your suggested changes.
@trebmuh are you interested in reading the document? I have put a current copy online. http://jpcima.sdf1.org/software/documentation/ADLplug/manual/en/manual.html
@jpcima @bsutherland , I did a read on it and here are some findings (hopefully right!):
general: not specific to the EN version
If you encounter a problem with the software, please create an issue on the project page: https://github.com/jpcima/ADLplug
-> @jpcima : what about linking straight to the issues tracker? (https://github.com/jpcima/ADLplug/issues).
Binary downloads are provided for both Windows and Mac.
-> Binary downloads are provided for both Windows, Mac and Debian.
Specific to the EN version:
ADLplug is an FM synthesizer
-> ADLplug is a FM synthesizer
2 or 4 operator
-> 2 or 4 operators
It is usually written "plugin", but once it's written "plug-in" (in Description). It'd be good to be consistent (ie: keeping plugin everywhere).
Another bank an be selected from the included collections.
-> Another bank can be selected from the included collections.
Each operator in an algorithm acts as either a modulator or a carrier.
-> Each operator in an algorithm that acts as either a modulator or a carrier.
The OPL3 has three classes of algorithm:
-> The OPL3 has three classes of algorithms:
(not sure)
In 2op algorithms
-> In 2op algorithm
in gray
-> in grey
The release ® parameter
-> The release (R) parameter
which make it more suitable
-> which makes it more suitable
The ADplug software was developed
-> The ADLplug software was developed
Overall, great job @bsutherland ! Really great.
I hope that helps.
@trebmuh @jpcima Thank you for the reviews! I will take a closer look and update the files later today.
@trebmuh Thanks again for the proofreading, good catches. I applied most of your suggestions. In a couple of cases where I didn't, I'll comment inline with explanations.
@trebmuh has rightfully observed the documentation is not published under a license. I will publish under a dual LAL 1.3 / CC-BY-SA 4.0.
Is it fine with you @bsutherland? (probably, it's a little matter but would be indelicate of me to relicense the contribution without asking)
@jpcima Fine by me! Thanks for checking.
Also, please feel free to edit the commit history (eg squash, rebase) if you prefer.
I tried to translate it as faithfully as possible. Used Google Translate, DeepL, and Cambridge French-English dictionary to guide me.
Please feel free to let me know if you have any questions or requests.