search

jpcima / ADLplug

FM Chip Synthesizer — OPL & OPN — VST/LV2/Standalone
Boost Software License 1.0
426 stars 22 forks source link

Fix compilation on systems using unsigned chars by default #60

Closed jfrey-xx closed 4 years ago

jfrey-xx commented 4 years ago

Hello,

Here is a small fix I had to perform in order to compile on Raspberry Pi (v4, using an image based on Debian 10 Buster from the Zynthian project http://zynthian.org/ ). Because it appears that the char type is not standard and varies between platforms, an error was raised during the compilation of resources.cc.

With this fix everything appears functional -- and on a side note I do not think it would require much work to fully integrate this wonderful wrapper in Zynthian, e.g. the possibility to switch banks and set parts from LV2 parameters.

jpcima commented 4 years ago

Hi, thanks for letting me know of this issue. I've fixed this at the resource compiler, such that it doesn't need a gcc compiler flag to fix it. I prefer to keep the build compiler-neutral.

In the new revision of resources.cc, the file must build regardless of architecture.

jfrey-xx commented 4 years ago

Indeed this is a way better method; thanks for the quick fix, I confirm it compiles on the Pi and everything looks normal :+1: