jpcima / adljack

OPL3/OPN2 synthesizer using ADLMIDI and OPNMIDI, for Jack and cross-platform audio
Boost Software License 1.0
41 stars 3 forks source link

Bad display of cyrillic characters #16

Closed jpcima closed 4 years ago

jpcima commented 4 years ago

@Wohlstand has reported the files with cyrillic characters as displaying incorrectly. The locale used was ru_RU.UTF-8. I couldn't reproduce it.

Снимок экрана от 2019-09-30 11-16-42

Wohlstand commented 4 years ago

Any non-ASCII, the same fails with Japanese: Снимок экрана от 2019-09-30 12-06-06

jpcima commented 4 years ago

Please check if it does same with a PREFER_PDCURSES=ON build, to verify if problem is terminal related.

Wohlstand commented 4 years ago

With PDCurses is same: Снимок экрана от 2019-09-30 12-15-00 The fact, this happens at my job PC but doesn't happen at my home, however, It was at my home also until some moment... (with no-PDCurses build)

jpcima commented 4 years ago

It's normal that pdcurses doesn't show cyrillic, as it doesn't have the bitmap font for it. What's shown is expected currentbehavior.

But still, it does indicate a thing: it does not translate into these "M-" bizarre char sequences. Is MATE-terminal the terminal emulator used?

Wohlstand commented 4 years ago

It's not MATE, it's XFCE4's terminal Снимок экрана от 2019-09-30 12-32-15

Wohlstand commented 4 years ago

The same happens with Gnome terminal also. Is that because of ncurses-side setup? Or ncrurses/ncursesw?

jpcima commented 4 years ago

Seems I didn't have more luck reproducing this on XFCE one. Ncurses is supposed to be the ncursesw one.

jpcima commented 4 years ago

Hi, I confirm non-wide ncurses as not displaying correct characters. Make sure that it's ncursesw the library linked into adlrt. In CMake, ordinary ncurses is picked as fallback, probably I shouldn't do that.

Wohlstand commented 4 years ago

So, I had that crap even libncursesw5-dev was installed, however, yeah, I have nuked entire "build" folder and I have ran build from scratch, so, the problem has gone, finally! :fox_face: Снимок экрана от 2019-10-03 14-07-00

jpcima commented 4 years ago

Great. :+1: :fox_face: In the last commit, I forced linking the wide ncurses versions.