jpcima / faustpp

A post-processor for faust, which allows to generate with more flexibility
Boost Software License 1.0
23 stars 3 forks source link

Allow to use internal boost version provided by jinja2cpp #10

Closed falkTX closed 2 years ago

falkTX commented 2 years ago

This allows to build faustpp without needing to install boost, which is quite handy for cross-compilation or simply reducing the number of 3rd party libs for building.

I am actually a bit confused by it tbh, because it seems the way cmake is setup at the moment that jinja2cpp will always use its internal boost version, so there could be symbol conflicts at link time? Because you include jinja code directly for the build objects, always using its contained boost version should be something to consider.

falkTX commented 2 years ago

I had libboost-dev installed and did not notice, so build was succeeding while using system headers. Now actually correct. Verified it builds on Linux, attempted on Windows too (with mingw) but failed as it is not supported yet.

jpcima commented 2 years ago

This project checks out the entirety of boost as submodule, which makes it quite difficult to deal with. And it is questionable whether it is maintained, considering the main author has not made a commit in a long time.

tbh I might just give up and depend on python jinja instead.

jpcima commented 2 years ago

This work is no longer relevant because the c++ implementation is replaced. Thanks regardless.