jpcima / smf-dsp

Advanced MIDI file player
Boost Software License 1.0
47 stars 5 forks source link

MUS support? #17

Closed freq-mod closed 4 years ago

freq-mod commented 4 years ago

Great player, thanks for it.

Yet one thing it lacks is .mus support, since both libADL and libOPNMIDI can handle it. Would it be possible to add that?

jpcima commented 4 years ago

Hello,

yes based on a quick read of the MUS document, this must be probably not too difficult. I'll add it.

freq-mod commented 4 years ago

http://www.shikadi.net/moddingwiki/MUS_Format - comprehensive documentation of the format, hope it helps

jpcima commented 4 years ago

Added at 1ffb907 let me know if all is fine.

freq-mod commented 4 years ago

Quick test - something seems to be wrong with instrument volumes, some notes are cut short

freq-mod commented 4 years ago

x.zip - recordings of a file played in SMF-DSP with libOPNMIDI synth, libOPNMIDIplay and .mus file

jpcima commented 4 years ago

Ok I adjusted so it produces more or less the same MIDI stream. There was a state handling problem with velocity, and also a lack of initialization of channel volumes.

freq-mod commented 4 years ago

Seems OK now, thanks a lot!