search

jpcima / smf-dsp

Advanced MIDI file player
Boost Software License 1.0
47 stars 5 forks source link

Add more GS MIDI resets #29

Closed freq-mod closed 3 years ago

freq-mod commented 3 years ago

The sequel to #24 - sometimes, MIDI program names still won't appear. GSMIDI.zip - contain a few examples of such songs. Most of these should be Edirol SD-20/SC-8820, however PASSPORT.MID and CANYON.MID... aren't they plain SC-55 songs? Why is one instrument name not recognized?

jpcima commented 3 years ago

These do not have an explicit reset. The best way to handle these is that the software scans the file for programs to match them against the database, and use this information to detect the midi specification.

jpcima commented 3 years ago

Anyway, I should send systematically a reset before new tracks, because some of the synths have problems resetting with just the GM sequence. So I'll do like this: if file lacks a reset sequence at the start, I'll scan the file to identify which MIDI spec it belongs to, and then I'll send the matching reset.

jpcima commented 3 years ago

This is supposed to be fixed in 00c609f. Let me know if there are problems.

freq-mod commented 3 years ago

I would say it's OK, yet one minor problem: MushiHS_Stage2.mid.zip

Channel 10 percussion set track name is blank, can anything de done about it?

jpcima commented 3 years ago

Done, the fall back will apply to percussion banks also

freq-mod commented 3 years ago

Thanks! If I find a song that can't fall back, I will reopen this issue.