search

jpcima / spectacle

Realtime graphical spectrum analyzer
ISC License
60 stars 5 forks source link

Resizing LV2 in Carla doesn't change the canvas size #11

Open unfa opened 3 years ago

unfa commented 3 years ago

I've tested the plug-in in Carla today and resizing does't seem to work.

I can resize the window, but the plug-in still redraws only the same area of it, leaving the rest with garbage.

jpcima commented 3 years ago

Carla is not letting the plugin know about the resize. puglReshape not called, but working in Jalv @falkTX, perhaps you have an idea of why that is?

unfa commented 3 years ago

Interestingly Wolf Spectrum does resize correctly in Carla (it does not in Ardour though).

jpcima commented 3 years ago

Right thats' because Patrick cheated it, he implements his custom resize handle. This issue is with WM-managed resizing.

unfa commented 3 years ago

I think this is an issue with LV2 in general. I don't know about VST3, but LV2 plug-ins have issues with resizing all the time. Maybe we're lacking some standardized way of communicating this?

jpcima commented 3 years ago

Highly doubtful, I'll dig in Carla later to check what really happens

jpcima commented 3 years ago

Ok it comes down to this, an unimplemented in DPF return 1; // This needs more testing

For reference https://github.com/DISTRHO/DPF/blob/89cbdbba5320c8f8822885b510307bef0c7a428f/distrho/src/DistrhoUILV2.cpp#L509-L510

falkTX commented 3 years ago

resizing has been a problematic thing in dpf (partially because of pugl) I am reworking the dgl/graphics stuff in dpf right now, which should fix this situation but will take some time until it is complete. You can follow the (re)work at https://github.com/DISTRHO/DPF/commits/pugl-upstream-v2 But not much to see at this point.

luzpaz commented 11 months ago

Is this still an issue ?