search

jpcima / ysfx

Hosting library for JSFX
Apache License 2.0
159 stars 25 forks source link

cmake.deps creates a dl target #34

Closed jcelerier closed 2 years ago

jcelerier commented 2 years ago

This conflicts with the CMAKE_DL_LIBS variable: https://cmake.org/cmake/help/latest/variable/CMAKE_DL_LIBS.html

if another project uses CMAKE_DL_LIBS and includes ysfx, things may go awry due to dl now being a target:

CMake Error in 3rdparty/libossia/3rdparty/Servus/servus/CMakeLists.txt:
  export called with target "Servus_iface" which requires target "dl" that is
  not in any export set.

-- Generating done
CMake Error in 3rdparty/libossia/3rdparty/wiiuse/src/CMakeLists.txt:
  export called with target "wiiuse" which requires target "dl" that is not
  in any export set.
jpcima commented 2 years ago

It's fixed.

jcelerier commented 2 years ago

thanks !

jpcima commented 2 years ago

@jcelerier Good job with ossia score btw, will you integrate the graphics as well?

jcelerier commented 2 years ago

yep, seems to work just fine on linux, just have to test on mac & win32 now :)