jpcima / ysfx

Hosting library for JSFX
Apache License 2.0
159 stars 25 forks source link

small GUI with the ConsoleMeter from Tukan #65

Open xhub opened 1 year ago

xhub commented 1 year ago

First of all, thanks a lot for your work on this. It's amazing!

When opening the ConsoleMeter plugin from https://github.com/TukanStudios/TUKAN_STUDIOS_PLUGINS in ysfx, the display is very small, see below ysfx-GUI-small Changing the windows size does not influence the size.

Within Reaper, making the window bigger scales the displayed part ysfx-GUI-reaper

This is with the current master on linux (Gentoo).

jpcima commented 1 year ago

Hi, indeed, the resized editor window does not currently modify the size of the jsfx graphics area. Reaper would modify the values of gfx_w, gfx_h to match the view size.

Ysfx would assume a graphics area to be fixed size or programmatically-sized; and on resize, just recenters the gfx view into the editor. This behavior is implemented in YsfxEditor::Impl::relayoutUI.

Will fix when I have a bit of time.

xhub commented 1 year ago

Thanks for your quick reply. I tried to scale it by having gfx_{h,w} set to better value, but it's more involved than that and hence above my limited understanding of jsfx. Looking forward to your changes.

jpcima commented 1 year ago

If you would like to edit the script, check near @gfx where default width and height are defined @gfx 190 88

xhub commented 1 year ago

Thanks, setting it to @gfx 800 200 provides a good workaround